-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project: Virtual Private Cloud #381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Ye Chen <[email protected]>
zliang-akamai
added
enhancement
breaking-change
for breaking changes in the changelog.
labels
Sep 13, 2023
zliang-akamai
added
New Product
and removed
enhancement
breaking-change
for breaking changes in the changelog.
labels
Oct 4, 2023
* add negative test cases * address pr comment * spelling
Prod fixtures
zliang-akamai
requested review from
lgarber-akamai and
vshanthe
and removed request for
a team
November 6, 2023 16:28
zliang-akamai
force-pushed
the
proj/vpc
branch
from
November 6, 2023 17:03
77af41e
to
b38fbd6
Compare
zliang-akamai
requested review from
a team,
jriddle-linode,
amisiorek-akamai and
ykim-akamai
and removed request for
a team
November 6, 2023 21:43
lgarber-akamai
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work everyone 🎉
zliang-akamai
changed the title
project: Virtual Private Cloud
Project: Virtual Private Cloud
Nov 7, 2023
jriddle-linode
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding VPC related functionalities to
linodego
.All related test cases can be ran by:
make fixtures ARGS="-run TestVPC"
make fixtures ARGS="-run TestInstance_ConfigInterface"
Thanks everyone for the effort to support VPC in
linodego
!